Improve error message

This commit is contained in:
Peter Butzhammer
2024-07-22 14:18:03 +02:00
parent 636c56d252
commit f90ad5f9be

View File

@@ -120,7 +120,7 @@ internal class VariableNameParser : IVariableNameParser
{ {
if (defaultValue.HasValue) if (defaultValue.HasValue)
return defaultValue.Value; return defaultValue.Value;
throw new InvalidS7AddressException($"Variable of type {type} must have a length set \"{input}\"", input); throw new InvalidS7AddressException($"Variable of type {type} must have a length set. Example \"db12.byte10.3\", found \"{input}\"", input);
} }
if (!ushort.TryParse(match.Groups["bitOrLength"].Value, out var result)) if (!ushort.TryParse(match.Groups["bitOrLength"].Value, out var result))
@@ -132,7 +132,7 @@ internal class VariableNameParser : IVariableNameParser
byte GetBit() byte GetBit()
{ {
if (!match.Groups["bitOrLength"].Success) if (!match.Groups["bitOrLength"].Success)
throw new InvalidS7AddressException($"Variable of type {type} must have a bit number set \"{input}\"", input); throw new InvalidS7AddressException($"Variable of type {type} must have a bit number set. Example \"db12.bit10.3\", found \"{input}\"", input);
if (!byte.TryParse(match.Groups["bitOrLength"].Value, out var result)) if (!byte.TryParse(match.Groups["bitOrLength"].Value, out var result))
throw new InvalidS7AddressException($"\"{match.Groups["bitOrLength"].Value}\" is an invalid bit number in \"{input}\"", input); throw new InvalidS7AddressException($"\"{match.Groups["bitOrLength"].Value}\" is an invalid bit number in \"{input}\"", input);